Dan Kenigsberg has posted comments on this change. Change subject: core: HandleVdsVersion uses only compat level (#822158) ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) If you do decide to remove getSupportedENGINESVersionsSet(), please do it in a separate patch, and drop the function definition as well. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java Line 62 As much as I love deleting code, I think that you should not drop getSupportedENGINESVersionsSet() out of hand. This functions facilitates future Vdsms to say that a specific Engine from the field is actually tested to be fine with it. Personally, I never understood why protocolLevel was not enough for everything, but please discuss this removal with the folks that wanted it (iheim is one of them). -- To view, visit http://gerrit.ovirt.org/4504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32a562cecc472e829cafaf9551f055d7466ca03c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
