Yair Zaslavsky has posted comments on this change. Change subject: core: HandleVdsVersion uses only compat level (#822158) ......................................................................
Patch Set 3: At the patch I removed only usage of getSupportedENGINESVersionsSet() (as you can see, it's a method of VDS, and I haven't removed it from the VDS entity). At the inline comment you suggested to keep the method for future usage, and actually this is what I'm doing. Besides that, I agree with you about further consulting about this. If I didn't understand you correctly, feel free to comment. Thanks! -- To view, visit http://gerrit.ovirt.org/4504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32a562cecc472e829cafaf9551f055d7466ca03c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
