Juan Hernandez has posted comments on this change. Change subject: engine: RFE: set locale language and keyboard via Sysprep ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24838/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 2504: <xs:element ref="nic_configurations" minOccurs="0" maxOccurs="1"/> Line 2505: <xs:element name="windows_license_key" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2506: <xs:element name="root_password" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2507: <xs:element name="custom_script" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2508: <xs:element name="setup_ui_language_ui_language" type="xs:string" minOccurs="0" maxOccurs="1"/> Really weird name. Can you add some comments explaining what are the purposes of the these settings? Line 2509: <xs:element name="input_locale" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2510: <xs:element name="ui_language" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2511: <xs:element name="system_locale" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2512: <xs:element name="user_locale" type="xs:string" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/24838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica4e2edf34a49c907ba32fa0a14bf6a4e4527cf4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
