Juan Hernandez has posted comments on this change. Change subject: engine: RFE: set locale language and keyboard via Sysprep ......................................................................
Patch Set 5: I think it isn't good to make the RESTAPI so close to what sysprep requires, specially the setup_ui_langue_ui_language element. If we do this then any change in the layout of sysprep itself will render us obsolete. It is better if we do something more neutral, that can by applied to sysprep or to, for example, cloud-init. If I understand correctly that element indicates the language that Windows will use during the setup. It is optional, and not very important: http://technet.microsoft.com/en-us/library/cc766484%28v=ws.10%29.aspx I think we can put there the same value that goes in ui_language, and avoid having that element in the RESTAPI. So we can have the following elements in the RESTAPI: <input_locale>...<input_locale> <system_locale>...</system_locale> <user_locale>...</user_locale> <system_language>...</system_language> And them populate the SetupUILanguage->UILanguage with the value of <system_language>. -- To view, visit http://gerrit.ovirt.org/24838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica4e2edf34a49c907ba32fa0a14bf6a4e4527cf4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
