Martin Sivák has posted comments on this change. Change subject: Update the build process to determine versioning using git tags ......................................................................
Patch Set 1: Alon: Thanks for the comment, but regarding autogen.sh and the release_suffix I can only provide one answer: "Citation needed" And do not take it in a bad way, I only want to know what guidelines are we using so we can unify that across all projects (considering that using autotools for pure python project is also something I do not like). Btw I do not agree with the release_suffix at all, because I used to be (and still am) Fedora packager and the meaning of Version and Release is clearly defined in http://www.rpm.org/max-rpm/ch-rpm-file-format.html. We have issue with this in oVirt because we mix upstream and downstream terminology. - The autoritative release upstream (distribution wise) is the tarball anybody can use. - The rpm we build is using that tarball and so is downstream and has to use the full tarball's (upstream) version in the Version field. -- To view, visit http://gerrit.ovirt.org/25404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacfec13ee13abf05c781d820e865b2d4d54398ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
