Alon Bar-Lev has posted comments on this change.

Change subject: Update the build process to determine versioning using git tags
......................................................................


Patch Set 1:

hello martin,

pre-release should not be published at fedora so these guidelines do not apply.

as for pre-release tarballs, you can take an example from openvpn if you like, 
however what we do is provide VERSION_SUFFIX at autoconf with proper milestone 
so you get _master for snapshots and _betaX/_rcX for pre-release milestones 
which is what can be published if any at public.

so if you take milestone builds you are ok both upstream and downstream, as 
like an upstream project.

no need for adding any git magics.

now, let's begin from scratch and describe what is missing.

-- 
To view, visit http://gerrit.ovirt.org/25404
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfec13ee13abf05c781d820e865b2d4d54398ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to