Liron Ar has posted comments on this change. Change subject: core: change domains status to unknown when there are no reporting hosts ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25542/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java: Line 23: storageDomainStatuses.add(StorageDomainStatus.Active); Line 24: storageDomainMonitoredStatus = Collections.unmodifiableSet(storageDomainStatuses); Line 25: } Line 26: Line 27: public static Map<String, String> buildStoragePoolDomainsMap(List<StoragePoolIsoMap> storagePoolIsoMaps) { this method was moved from - http://gerrit.ovirt.org/#/c/25542/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java and isn't directly related to this patch. Line 28: Map<String, String> storageDomains = new HashMap<String, String>(); Line 29: Line 30: for (StoragePoolIsoMap domain : storagePoolIsoMaps) { Line 31: if (domain.getStatus() == StorageDomainStatus.Maintenance) { Line 44: StorageDomainStatus newStatus) { Line 45: List<StoragePoolIsoMap> storagesStatusInPool = DbFacade.getInstance() Line 46: .getStoragePoolIsoMapDao().getAllForStoragePool(storagePoolId); Line 47: for (StoragePoolIsoMap storageStatusInPool : storagesStatusInPool) { Line 48: if (storageStatusInPool.getStatus() != null this check was left because this copy has been moved from here - http://gerrit.ovirt.org/#/c/25542/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java Line 49: && storageStatusInPool.getStatus() != newStatus Line 50: && applicableStatusesForUpdate.contains(storageStatusInPool.getStatus())) { Line 51: storageStatusInPool.setStatus(newStatus); Line 52: DbFacade.getInstance() -- To view, visit http://gerrit.ovirt.org/25542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
