Michael Kublin has posted comments on this change. Change subject: core:Support remove of shareable disk. ......................................................................
Patch Set 7: (4 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java Line 143: */ same method name again? Line 197: validDisktoDelete = validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) I don't think that we need to run ImagesHandler.PerformImagesCheck on the same image for all vms, possible can be run only once Line 210: Arrays.asList(disk)); break; - keyword in java that used to break a loops Line 233: // TODO: Cleanup getVmId(), after refactor to remove container id and image id from image. what vmId will be here now? How it is relevant? -- To view, visit http://gerrit.ovirt.org/4490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
