Maor Lipchuk has posted comments on this change. Change subject: core:Support remove of shareable disk. ......................................................................
Patch Set 7: (4 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java Line 143: */ The command extends from command base. Line 197: validDisktoDelete = validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) It is a refactoring that I would prefer to do in a later patch Line 210: Arrays.asList(disk)); I did that with indication parameter validDisktoDelete, it should also work Line 233: // TODO: Cleanup getVmId(), after refactor to remove container id and image id from image. The vm id should be the vm that we had before, it should be removed in the clean ups patches, after the attach will be merged -- To view, visit http://gerrit.ovirt.org/4490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
