Ori Liel has posted comments on this change. Change subject: restapi : Missing opertions for snapshots in RESTAPI ......................................................................
Patch Set 10: (2 comments) Looks good, just change the names of the actions: preview --> preview_snapshot commit --> commit_snapshot undo --> undo_snapshot http://gerrit.ovirt.org/#/c/24056/10/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java: Line 111: @POST Line 112: @Formatted Line 113: @Consumes({ApiMediaType.APPLICATION_XML, ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML}) Line 114: @Actionable Line 115: @Path("preview") Since you are in the context of a VM, the new actions should have '_snapshot' suffix, to make it clear that they deal with snapshots: preview_snapshot, commit_snapshot, undo_snapshot Line 116: public Response previewSnapshot(Action action); Line 117: Line 118: @POST Line 119: @Formatted http://gerrit.ovirt.org/#/c/24056/10/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 364: urlparams: {} Line 365: headers: Line 366: Content-Type: {value: application/xml|json, required: true} Line 367: Correlation-Id: {value: 'any string', required: false} Line 368: - name: /api/vms/{vm:id}/preview|rel=preview Since you are in the context of a VM, the new actions should have '_snapshot' suffix, to make it clear that they deal with snapshots: preview_snapshot, commit_snapshot, undo_snapshot Line 369: request: Line 370: body: Line 371: parameterType: Action Line 372: signatures: -- To view, visit http://gerrit.ovirt.org/24056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c6d25daf7e716a7c857295b6ceb1741cbaf7f7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
