Ori Liel has posted comments on this change. Change subject: restapi : Missing opertions for snapshots in RESTAPI ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/24056/11/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java: Line 249: Line 250: @Override Line 251: public Response undoSnapshot(Action action) { Line 252: RestoreAllSnapshotsParameters restoreParams = new RestoreAllSnapshotsParameters(guid, SnapshotActionEnum.UNDO); Line 253: Response response = doAction(VdcActionType.RestoreAllSnapshots, sorry, just noticed this - you should be calling performAction() and not doAction(). Line 254: restoreParams, Line 255: action); Line 256: return response; Line 257: } Line 258: Line 259: @Override Line 260: public Response commitSnapshot(Action action) { Line 261: RestoreAllSnapshotsParameters restoreParams = new RestoreAllSnapshotsParameters(guid, SnapshotActionEnum.COMMIT); Line 262: Response response = doAction(VdcActionType.RestoreAllSnapshots, you should be calling performAction() and not doAction(). Line 263: restoreParams, Line 264: action); Line 265: return response; Line 266: } Line 268: @Override Line 269: public Response previewSnapshot(Action action) { Line 270: TryBackToAllSnapshotsOfVmParameters tryBackParams = Line 271: new TryBackToAllSnapshotsOfVmParameters(guid, asGuid(action.getSnapshot().getId())); Line 272: Response response = doAction(VdcActionType.TryBackToAllSnapshotsOfVm, you should be calling performAction() and not doAction(). Line 273: tryBackParams, Line 274: action); Line 275: return response; Line 276: } -- To view, visit http://gerrit.ovirt.org/24056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c6d25daf7e716a7c857295b6ceb1741cbaf7f7 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
