Martin Betak has posted comments on this change. Change subject: backend: Set Vm.current_cd on RunOnce ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25585/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 738: public static void updateCurrentCd(VM vm, String currentCd) { Line 739: VmDynamicDAO vmDynamicDao = DbFacade.getInstance().getVmDynamicDao(); Line 740: VmDynamic vmDynamic = vm.getDynamicData(); Line 741: vmDynamic.setCurrentCd(currentCd); Line 742: vmDynamicDao.update(vmDynamic); > you should use UpdateVmDynamicData vds command, in order to lock monitorin Done Line 743: } Line 744: http://gerrit.ovirt.org/#/c/25585/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 1248: setVmHost(vm.getVmHost()); Line 1249: setVmIp(vm.getVmIp()); Line 1250: setVmFQDN(vm.getVmFQDN()); Line 1251: // update only if vdsm actually provides some value, otherwise engine has more information Line 1252: if (vm.getCurrentCd() != null) { > but what if user is doing eject? Eject is represented as empty string "" (!= null) Line 1253: setCurrentCd(vm.getCurrentCd()); Line 1254: } Line 1255: Line 1256: // if (!string.IsNullOrEmpty(vm.app_list)) -- To view, visit http://gerrit.ovirt.org/25585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc4fbfae15e902898859dddf3cdffe9301dab2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
