Juan Hernandez has posted comments on this change. Change subject: backend: Set Vm.current_cd on RunOnce ......................................................................
Patch Set 3: Code-Review+1 (1 comment) The RESTAPI part looks good. http://gerrit.ovirt.org/#/c/25585/3/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java: Line 51: return notFound(); Line 52: } Line 53: // change the iso path so the result of 'map' will contain current cd instead of the Line 54: // persistent configuration Line 55: vm.setIsoPath(vm.getCurrentCd()); > what if the vm is down? or if it wasn't started yet (and iso path is set)? Actually, if I understand correctly, this is more correct than it was before, because it always sets the RESTAPI current cd to whatever the backend has, whilst before in some cases (when getCurrentCd() returns null) it used the persistent CD. Line 56: return addLinks(populate(map(vm), vm)); Line 57: } else { Line 58: return super.get(); Line 59: } -- To view, visit http://gerrit.ovirt.org/25585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc4fbfae15e902898859dddf3cdffe9301dab2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
