Alon Bar-Lev has posted comments on this change. Change subject: core: Remove error message when reports.xml doesn't exist ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/25324/6/backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingServletTest.java File backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingServletTest.java: Line 69: Line 70: @Test Line 71: public void testDoGet_NotFound_MissingFile() throws IOException, ServletException { Line 72: final IConfigUtilsInterface configUtils = Mockito.mock(IConfigUtilsInterface.class); Line 73: Config.setConfigUtils(configUtils); are you sure this is required? Line 74: Line 75: // The file should not exist, and thus return a 404. Line 76: testServlet.doGet(mockRequest, mockResponse); Line 77: verify(mockResponse).sendError(HttpServletResponse.SC_NOT_FOUND); http://gerrit.ovirt.org/#/c/25324/6/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 552: CLOSE v_tasks_cursor; Line 553: -- return full set of generated records Line 554: RETURN; Line 555: END; $procedure$ Line 556: LANGUAGE plpgsql; not part of this patch -- To view, visit http://gerrit.ovirt.org/25324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf6b075eb4754c5bb4153da8c6032a01bf801516 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
