Alon Bar-Lev has posted comments on this change. Change subject: core: Remove error message when reports.xml doesn't exist ......................................................................
Patch Set 5: (5 comments) please separate the required to own patch. http://gerrit.ovirt.org/#/c/25324/5/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/FileServlet.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/FileServlet.java: Line 109: // is the base file required Line 110: final String isBaseRequired = config.getInitParameter(REQUIRED); Line 111: if (isBaseRequired != null) { Line 112: required = Boolean.parseBoolean(isBaseRequired); Line 113: } move this block above where all parameters are handled? Line 114: } Line 115: Line 116: @Override Line 117: protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { Line 119: File file = ServletUtils.makeFileFromSanePath(request.getPathInfo(), base); Line 120: file = checkForIndex(request, response, file, request.getPathInfo()); Line 121: // Send the content of the file: Line 122: // type is the default MIME type of the Servlet. Line 123: ServletUtils.sendFile(request, response, file, type, cache, file == base && required); remove file==base as the entire tree should be effected. Line 124: } Line 125: Line 126: protected File checkForIndex(HttpServletRequest request, HttpServletResponse response, File file, String path) throws IOException { Line 127: // If the requested file is a directory then try to replace it with the http://gerrit.ovirt.org/#/c/25324/5/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java: Line 83: final HttpServletResponse response, Line 84: final File file, Line 85: final String defaultType, Line 86: boolean cache, Line 87: boolean showError) throws IOException { use same term? "required" or sync term backward. Line 88: Line 89: // Make sure the file exits and is readable and send a 404 error Line 90: // response if it doesn't: Line 91: if (!canReadFile(file)) { http://gerrit.ovirt.org/#/c/25324/5/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java: Line 29 Line 30 Line 31 Line 32 Line 33 not related to this patch http://gerrit.ovirt.org/#/c/25324/5/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 553: -- return full set of generated records Line 554: RETURN; Line 555: END; $procedure$ Line 556: LANGUAGE plpgsql; Line 557: no related to this patch Line 558: -- Remove a value from a CSV string in vdc_options Line 559: Create or replace FUNCTION fn_db_remove_csv_config_value(v_option_name varchar(100), v_value varchar(4000), v_version varchar(40)) Line 560: returns void Line 561: AS $procedure$ -- To view, visit http://gerrit.ovirt.org/25324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf6b075eb4754c5bb4153da8c6032a01bf801516 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
