Shahar Havivi has posted comments on this change.
Change subject: Engine: Enable Cloud-Init SSH login via public key
......................................................................
Patch Set 1:
(1 comment)
Greg
Is there a reason that we want to work with root instead of regular user?
referring to CloudInitHandler comment:
// Don't create ec2-user
userData.put("user", "root");
http://gerrit.ovirt.org/#/c/25625/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java:
Line 216: // set disable_root=0 for enabling root ssh login and
Line 217: // datasource_list in cloud.cfg
Line 218: bootcmd.add("sed -i '/^disable_root: /d'
/etc/cloud/cloud.cfg");
Line 219: bootcmd.add("echo 'disable_root: 0' >> /etc/cloud/cloud.cfg");
Line 220: bootcmd.add("sed -i '/^datasource_list: /d'
/etc/cloud/cloud.cfg");
> consider single sed:
I think that separating the command is more readable for maintaining the code
Line 221: bootcmd.add("echo 'datasource_list: [\"NoCloud\",
\"ConfigDrive\"]' >> /etc/cloud/cloud.cfg");
Line 222: userData.put("bootcmd", bootcmd);
Line 223:
Line 224: Map<String, Object> opts = new HashMap<String, Object>();
--
To view, visit http://gerrit.ovirt.org/25625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb48fe4306f803aca801c03ddf29f010eaeb635f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
