Oved Ourfali has posted comments on this change.

Change subject: Engine: Enable Cloud-Init SSH login via public key
......................................................................


Patch Set 2:

Usually cloud-init works with a specific (non-root) user.
In EC2 it is ec2-user
In fedora cloud image it is fedora
In ubuntu cloud image it is ubuntu
In centos cloud image it is centos (iirc).

All the users above have sudo permissions to root in the cloud image.

Now, the changes in this patch will make it work well for the user "root", but 
we need to think whether we want to go there or not.

My gut feeling is that we should completely eliminate all the user 
configuration, just passing the public SSH key. 
That key will be applied to the default user (according to the cloud image), 
and it will be able to login and sudo.

So, if we want to keep using "root" then +1 from me too, but
IMO that's not the right way here.

-- 
To view, visit http://gerrit.ovirt.org/25625
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb48fe4306f803aca801c03ddf29f010eaeb635f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to