Ori Liel has posted comments on this change.
Change subject: restapi: Support Floating Disks
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
Line 193
But until now we *did not* have this map. Yeah, the line of code was there, but
the next line put with same key in the map with a different value.
It's like:
map.put("ori", 1);
map.put("ori", 2);
The second line completely overrides the first line, so removing the first line
has no effect.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
Line 35: public interface VmDiskResource extends DeviceResource<Disk>,
MeasurableResource {
Ok, I'll re-do the change and see if the problem I thought I had pops up again.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 251: headers: {}
I believe this is not good, because someone looking at this signature will get
the impression that he must pass <action/> for the regular delete.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 63: if (action.isDetach()) {
We must have different signatures, and we have different signatures for delete
elsewhere. Remember we must be backwards compatible and we must allow empty
delete, not force user to pass <action/> - breaks backwards compatibility.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java
Line 43: disk.setVm(new VM());
Good point, that I agree with, there should be no set of new VM()
--
To view, visit http://gerrit.ovirt.org/4665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314ba532b1a40286053f87bb4f0f3c90b5850b5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
