Michael Pasternak has posted comments on this change.
Change subject: restapi: Support Floating Disks
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 251: headers: {}
it's doesn't matter, the all idea of DOC type programming is that you have
single signature with body that you don't have to override.
i.e foo(PARAMS)
the two signatures that we have for delete:
delete()
delete(ACTION)
is only implementation detail to satisfy commonly used delete() requirement
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 63: if (action.isDetach()) {
it's doesn't matter, the all idea of DOC type programming is that you have
single signature with body that you don't have to override.
i.e foo(PARAMS)
the two signatures that we have for delete:
delete() delete(ACTION)
is only implementation detail to satisfy commonly used delete() requirement
and we do stay backward compatible, cause if signature doesn't have body
and you send it, it get ignored - this is by HTTP spec, so delete() will work
anyway even if you supply body in request
--
To view, visit http://gerrit.ovirt.org/4665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314ba532b1a40286053f87bb4f0f3c90b5850b5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
