Tal Nisan has uploaded a new change for review. Change subject: core: Added a query to return the number of VMs in a cluster ......................................................................
core: Added a query to return the number of VMs in a cluster Change-Id: I04b7bf0c6edf4e55d0e5d7ce5e7030ba974de5e2 Signed-off-by: Tal Nisan <[email protected]> Related-To: https://bugzilla.redhat.com/913234 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M packaging/dbscripts/vds_groups_sp.sql 5 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/25858/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java new file mode 100644 index 0000000..d2acf87 --- /dev/null +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java @@ -0,0 +1,15 @@ +package org.ovirt.engine.core.bll; + +import org.ovirt.engine.core.common.queries.IdQueryParameters; + +public class GetNumberOfVmsInVdsGroupByVdsGroupIdQuery<P extends IdQueryParameters> extends QueriesCommandBase<P> { + public GetNumberOfVmsInVdsGroupByVdsGroupIdQuery(P parameters) { + super(parameters); + } + + @Override + protected void executeQueryCommand() { + Integer numOfVms = getDbFacade().getVdsGroupDao().getVmsCountByClusterId(getParameters().getId()); + getQueryReturnValue().setReturnValue(numOfVms); + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index eea2d8f..4872854 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -92,6 +92,7 @@ GetVdsGroupByName(VdcQueryAuthType.User), GetVdsGroupsByStoragePoolId(VdcQueryAuthType.User), GetNumberOfActiveVmsInVdsGroupByVdsGroupId, + GetNumberOfVmsInVdsGroupByVdsGroupId, // Certificate GetCACertificate(VdcQueryAuthType.User), diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java index 8ccccec..fbf6e98 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java @@ -176,4 +176,11 @@ * @return */ List<VDSGroup> getClustersByClusterPolicyId(Guid clusterPolicyId); + + /** + * Retrieves the number of the VMs in the cluster + * @param vdsGroupId + * @return + */ + Integer getVmsCountByClusterId(Guid vdsGroupId); } diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java index 142d495..f060cf3 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java @@ -160,6 +160,14 @@ getCallsHandler().executeModification("UpdateVdsGroupEmulatedMachine", parameterSource); } + @Override + public Integer getVmsCountByClusterId(Guid vdsGroupId) { + MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("vds_group_id", vdsGroupId); + return getCallsHandler().executeRead("GetNumberOfVmsInCluster", + getIntegerMapper(), + parameterSource); + } + public List<VDSGroup> getTrustedClusters() { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("trusted_service", true); diff --git a/packaging/dbscripts/vds_groups_sp.sql b/packaging/dbscripts/vds_groups_sp.sql index 2972664..4f6fe89 100644 --- a/packaging/dbscripts/vds_groups_sp.sql +++ b/packaging/dbscripts/vds_groups_sp.sql @@ -257,3 +257,12 @@ LANGUAGE plpgsql; + +Create or replace FUNCTION GetNumberOfVmsInCluster(v_vds_group_id UUID) RETURNS SETOF BIGINT STABLE + AS $procedure$ +BEGIN + RETURN QUERY SELECT COUNT (vms.*) + FROM vm_static vms + WHERE vms.vds_group_id = v_vds_group_id AND vms.entity_type = 'VM';; +END; $procedure$ +LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/25858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I04b7bf0c6edf4e55d0e5d7ce5e7030ba974de5e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
