Tal Nisan has posted comments on this change. Change subject: core: Added a query to return the number of VMs in a cluster ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25858/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java: Line 8: } Line 9: Line 10: @Override Line 11: protected void executeQueryCommand() { Line 12: Integer numOfVms = getDbFacade().getVdsGroupDao().getVmsCountByClusterId(getParameters().getId()); > why integer and not int? i dont think this can return null Done Line 13: getQueryReturnValue().setReturnValue(numOfVms); Line 14: } http://gerrit.ovirt.org/#/c/25858/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java: Line 181: * Retrieves the number of the VMs in the cluster Line 182: * @param vdsGroupId Line 183: * @return Line 184: */ Line 185: Integer getVmsCountByClusterId(Guid vdsGroupId); > please also add a dao test Done - http://gerrit.ovirt.org/25930 -- To view, visit http://gerrit.ovirt.org/25858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b7bf0c6edf4e55d0e5d7ce5e7030ba974de5e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
