Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix apperance of empty profile ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25993/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 132: } Line 133: Line 134: private void createKerberosLdapAAAConfigurations() { Line 135: Line 136: for (String domain : Config.<String> getValue(ConfigValues.DomainName).split("[,]", 0)) { > this is limit... per documentation[1] actually, i was looking at the documentation, see their example. if you have a string "a,,,,", split("[,]",0) on it will return an array of single string - "a". split("[,],-1) will return an array with more strings, "a" and then several empty strings. So passing 0 makes more sense to me. what do you think? nothing to do with trailing spaces within the string, you are right about that - trim should be considered. Line 137: if (!domain.isEmpty()) { Line 138: Properties authConfig = new Properties(); Line 139: authConfig.put(ExtensionsManager.CLASS, Line 140: "org.ovirt.engine.extensions.aaa.builtin.kerberosldap.KerberosLdapAuthenticator"); -- To view, visit http://gerrit.ovirt.org/25993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9384f40ad061ec35c03c4fbcbd1dd70085526 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
