Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix apperance of empty profile ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25993/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 133: Line 134: private void createKerberosLdapAAAConfigurations() { Line 135: Line 136: for (String domain : Config.<String> getValue(ConfigValues.DomainName).split("[,]", 0)) { Line 137: if (!domain.isEmpty()) { > so at least trim()? sorry, yes. I agree about trim. Line 138: Properties authConfig = new Properties(); Line 139: authConfig.put(ExtensionsManager.CLASS, Line 140: "org.ovirt.engine.extensions.aaa.builtin.kerberosldap.KerberosLdapAuthenticator"); Line 141: authConfig.put(ExtensionsManager.PROVIDES, "org.ovirt.engine.authentication"); -- To view, visit http://gerrit.ovirt.org/25993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9384f40ad061ec35c03c4fbcbd1dd70085526 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
