Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Always regenerate jasper conf ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25998/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 545 Line 546 Line 547 Line 548 Line 549 > please move this info before export bellow What? I did! I might be missing something. Line 579 Line 580 Line 581 Line 582 Line 583 > I thought that this ^ is what you trying to solve, by looking only for the Indeed. Line 157: for entry in self._restore: Line 158: if os.path.exists(entry['dst']): Line 159: shutil.rmtree(entry['dst']) Line 160: Line 161: def _buildJs(self, cmd, config, customize=True): > took me a while to understand what customize is... maybe productIndependent > took me a while to understand what customize is... maybe productIndependent > or anything similar. Done > but how come you do not need the product suffix while the old generate > command needed it? No idea - perhaps it was changed. grep 'target.*gen-config' - there is only one. I also asked Yaniv and he said so. Line 162: Line 163: try: Line 164: myumask = os.umask(0o022) Line 165: -- To view, visit http://gerrit.ovirt.org/25998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I810cfae4e8ee4901e46fa49b46c7a8a41dde0bf1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
