mooli tayer has posted comments on this change. Change subject: engine: event should contain the iface which exceeded defined threshold ......................................................................
Patch Set 8: (1 comment) Alona, Can you please explain why do we use @deprecated on such audit log events and not delete them entirely? http://gerrit.ovirt.org/#/c/25609/8/packaging/dbscripts/upgrade/03_04_0650_add_host_interface_high_network_use_event.sql File packaging/dbscripts/upgrade/03_04_0650_add_host_interface_high_network_use_event.sql: Line 1: insert into event_map(event_up_name, event_down_name) values('HOST_INTERFACE_HIGH_NETWORK_USE', ''); I believe this can be removed. according to how the notifier works now we need records in event_map only if they have an event_up_name and an event_down_name (in which case a user subscribing to 'event_up_name' will also be notified on 'event_down_name'). Maybe we should have a patch cleaning the table too. -- To view, visit http://gerrit.ovirt.org/25609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b3510398ac6fa3acf93fcb596dd6ea10b26366 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
