mooli tayer has posted comments on this change. Change subject: engine: event should contain the iface which exceeded defined threshold ......................................................................
Patch Set 8: If you say deprecation is to handle existing audit_log rows at the user from before the upgrade @deprecate is less then ideal because the old value remains for good in the code(and "api" as you've said). why not remove the old value entirely and in the upgrade script delete the audit_log records or replace them with the new one(with partial data I guess). Then in event_map you can just delete the old one and no need to update with the new one. -- To view, visit http://gerrit.ovirt.org/25609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b3510398ac6fa3acf93fcb596dd6ea10b26366 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
