Eli Mesika has posted comments on this change.

Change subject: aaa: Change API to 3.3 behavior
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/25997/10/packaging/dbscripts/upgrade/03_05_0150_change_group_ids.sql
File packaging/dbscripts/upgrade/03_05_0150_change_group_ids.sql:

Line 37: );
can we avoid the 2nd temp table and do something like 

UPDATE users u SET group_ids = (
array_to_string(array_agg(group_id), ',')  FROM tmp_users_groups GROUP BY 
user_id)
WHERE user_id = u.user_id);


-- 
To view, visit http://gerrit.ovirt.org/25997
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff51fb9df33b4b679eba5b1c3ef2bea6ea7b3e07
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to