Yair Zaslavsky has posted comments on this change. Change subject: aaa: Change API to 3.3 behavior ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/25997/10/packaging/dbscripts/upgrade/03_05_0160_update_user_ids.sql File packaging/dbscripts/upgrade/03_05_0160_update_user_ids.sql: Line 17: SELECT temp_id FROM users WHERE user_id = m.user_id); Line 18: Line 19: UPDATE permissions p SET ad_element_id = ( Line 20: SELECT temp_id FROM users u1 WHERE u1.user_id = p.ad_element_id Line 21: ) WHERE EXISTS ( > Why do you need this WHERE, if it will not be found than UPDATE will do not I have tried it without the where part. didn't work. it tried setting NULL when the ad_element_id was not the user id. Line 22: SELECT user_id from users where user_id = p.ad_element_id Line 23: ); Line 24: Line 25: UPDATE users SET user_id = temp_id; -- To view, visit http://gerrit.ovirt.org/25997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff51fb9df33b4b679eba5b1c3ef2bea6ea7b3e07 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
