Ori Liel has posted comments on this change.
Change subject: core: [CpuPinning] restapi support for cpu pinning
......................................................................
Patch Set 9: (7 inline comments)
some comments inside, plus can you please add cpu pinning to
rsdl_metadata_v-3.1.yaml? This file is used to generate the RSDL, and method
parameters need to be documented there. Contact me if you need support for this
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 401: <xs:attribute name="cpuset" type="xs:string" use="required"/>
in other places where there are two words, we separate with underscore. So can
you please change to: cpu_set?
Line 406: <xs:element name="vcpupin" type="VCpuPin" minOccurs="0"
maxOccurs="unbounded"/>
in other places where there are two words, we separate with underscore. So can
you please change to: vcpu_pin?
Line 416: <xs:element name="cputune" type="CpuTune" minOccurs="0"
maxOccurs="1"/>
in other places where there are two words, we separate with underscore. So can
you please change to: cpu_tune?
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 217: }
for consistency, instead of using methods
- cpuTuneToString()
- stringToCpuTune()
you can have map() methods, such as:
@Mapping(from = CpuTune.class, to = String.class)
public static MigrationSupport map(CpuTune cpuTune, String template) {
...
}
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
Line 90: transform.getCpu().getTopology().getCores()) <
model.getCpu().getTopology().getSockets());
whitespace changes
Line 144: new
org.ovirt.engine.core.common.businessentities.VM();
whitespace changes
Line 175: org.ovirt.engine.core.common.businessentities.VM entity =
whitespace changes
--
To view, visit http://gerrit.ovirt.org/4557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa1e3b02997ff3e6af059ca151e3a6d12d6c4b4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
