Ori Liel has posted comments on this change.
Change subject: core: [CpuPinning] restapi support for cpu pinning
......................................................................
Patch Set 9: (2 inline comments)
About yaml - it should go in this patch. Send me a working xml (as written in
the http request), and I will write the yaml and send it to you. Then reload
the patch with it.
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 217: }
Not sure I understand your comment.
What I suggested (and it's not a must) is that instead of the methods:
- cpuTuneToString(CpuTune tune)
- stringToCpuTune(String cpuPinning)
You could have 'map()' methods:
Mapping(from = CpuTune.class, to = String.class)
public static String map(CpuTune cpuTune, String template) {
...
}
Mapping(from = String.class, to = CpuTune.class)
public static CpuTune map(String template, CpuTune cpuTune) {
...
}
It achieves the same - mapping a String to CpuTune object and vica-versa, but
it's more consistent with other mapping methods.
Maybe I confused you by mistakenly pasting 'MigrationSupport' as the return
value in my previous comment; that was just a copy-paste error)
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
Line 90: transform.getCpu().getTopology().getCores()) <
model.getCpu().getTopology().getSockets());
In my personal opinion no, but those are the standards in the project; I can
nack'ed for whitespace all the time:) If this was the only thing I wouldn't
comment on it, but you had some other changes to make anyway. At the end of the
day I don't really care; fix if you feel like it.
--
To view, visit http://gerrit.ovirt.org/4557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa1e3b02997ff3e6af059ca151e3a6d12d6c4b4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
