Einav Cohen has posted comments on this change. Change subject: webadmin: feedback tooltip ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25703/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java: Line 138: public void setFeedbackText(String feedbackText, String feedbackTitle) { Line 139: feedbackImagePanel.setVisible(true); Line 140: feedbackImageLabel.setText(feedbackText); Line 141: if (feedbackTitle != null) { Line 142: feedbackImageLabel.setTitle(feedbackTitle); > I think that having a "title" attribute is a good start, we can improve it Greg is right, we should have a consistent look and feel for all tool-tips in the system, and we are trying to move towards the blue panel-based tool-tips. we already have several "title" tooltips in the system, such as the one mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1023545; another example is tool-tips of grid-column titles for icon-titles or cropped-text-titles. we need to convert all of them to blue panel-based tool-tips at some point; in the mean time, let's not introduce new ones. @Alexander - although functionality may be the same, the look-and-feel is not the same. can we make the "title" tool-tips look like the blue panel-based ones? if not - we need to move the panel-based ones. thanks. Line 143: } Line 144: } Line 145: -- To view, visit http://gerrit.ovirt.org/25703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id17d0addf99645d2c8fb6f54ccafa0d4d688d177 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
