Alexander Wels has posted comments on this change. Change subject: webadmin: feedback tooltip ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25703/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java: Line 138: public void setFeedbackText(String feedbackText, String feedbackTitle) { Line 139: feedbackImagePanel.setVisible(true); Line 140: feedbackImageLabel.setText(feedbackText); Line 141: if (feedbackTitle != null) { Line 142: feedbackImageLabel.setTitle(feedbackTitle); > Only if you feel that your style is the only one that matters instead of le One more thing, the 'title' tooltip are the accepted way for screen readers/etc to interpret tooltips. Having custom ones like the ones we are proposing will make it impossible for those to interpret them (Besides the zillion other issues they will have with this application) Line 143: } Line 144: } Line 145: -- To view, visit http://gerrit.ovirt.org/25703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id17d0addf99645d2c8fb6f54ccafa0d4d688d177 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
