Yair Zaslavsky has posted comments on this change. Change subject: engine: Introduction of command entity dao ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/26337/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java: Line 121: // if the parentCommand Id is not null but parent parameters is null we rebuild the command hierarchy Line 122: if (!Guid.isNullOrEmpty(cmdEntity.getParentCommandId()) && command.getParameters().getParentParameters() == null) { Line 123: CommandBase<?> parentCommand = retrieveCommand(cmdEntity.getParentCommandId()); Line 124: if (parentCommand != null) { Line 125: command.getParameters().setParentParameters(parentCommand.getParameters()); Worth thinking here to change the methods of CommandBase in such a way you can perform command.getParentCommand() Line 126: } Line 127: } Line 128: } Line 129: return command; -- To view, visit http://gerrit.ovirt.org/26337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
