Ravi Nori has posted comments on this change. Change subject: engine: Introduction of command entity dao ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/26337/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java: Line 121: // if the parentCommand Id is not null but parent parameters is null we rebuild the command hierarchy Line 122: if (!Guid.isNullOrEmpty(cmdEntity.getParentCommandId()) && command.getParameters().getParentParameters() == null) { Line 123: CommandBase<?> parentCommand = retrieveCommand(cmdEntity.getParentCommandId()); Line 124: if (parentCommand != null) { Line 125: command.getParameters().setParentParameters(parentCommand.getParameters()); > Worth thinking here to change the methods of CommandBase in such a way you Hi Yair, what will be the return type of command.getParentCommand() and how do we intend to use it? Line 126: } Line 127: } Line 128: } Line 129: return command; http://gerrit.ovirt.org/#/c/26337/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java: Line 28: } Line 29: } Line 30: Line 31: @Override Line 32: public synchronized CommandEntity get(Guid commandId) { > not sure if i have asked this before - why synchronized? doesnt the cache w I think we can safely get rid of synchronized in this class Line 33: if (!cacheInitialized) { Line 34: initializeCache(); Line 35: cacheInitialized = true; Line 36: } http://gerrit.ovirt.org/#/c/26337/7/packaging/dbscripts/command_entities_sp.sql File packaging/dbscripts/command_entities_sp.sql: Line 25: AS $procedure$ Line 26: BEGIN Line 27: UPDATE command_entities Line 28: SET command_type = v_command_type , Line 29: parent_command_id = v_parent_command_id, > TWS, please remove Done Line 30: root_command_id = v_root_command_id, Line 31: action_parameters = v_action_parameters, Line 32: action_parameters_class = v_action_parameters_class, Line 33: created_at = v_created_at -- To view, visit http://gerrit.ovirt.org/26337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
