Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 19: (2 comments) http://gerrit.ovirt.org/#/c/26602/19/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java: Line 43: output.put(Authn.InvokeKeys.AUTH_RECORD, Line 44: new ExtMap().mput( Line 45: Authn.AuthRecord.PRINCIPAL, Line 46: adminUser Line 47: ) > please add LOGIN_SINCE with new Date().getTime() please ignore, this belongs to future accounting work. Line 48: ); Line 49: output.put(Authn.InvokeKeys.RESULT, Authn.AuthResult.SUCCESS); Line 50: } Line 51: } http://gerrit.ovirt.org/#/c/26602/19/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java: Line 91: configuration.getProperty("config.change.password.msg") Line 92: ).mput( Line 93: Authn.InvokeKeys.CREDENTIALS_CHANGE_URL, Line 94: configuration.getProperty("config.change.password.url" Line 95: ) > please add LOGIN_SINCE with new Date().getTime() please ignore, this belongs to future accounting work. Line 96: ); Line 97: } Line 98: Line 99: private String getAuthzName() { -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
