Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 19: (1 comment) http://gerrit.ovirt.org/#/c/26602/19/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java: Line 114: new LdapSearchByQueryParameters( Line 115: null, Line 116: getDirectoryName(), Line 117: queryData, Line 118: getValue(input.<Boolean> get(Authz.InvokeKeys.RESOLVE_GROUPS_RECURSIVE), false) > why not use: oh, forgot there is a default value option. cool. i'll change. Line 119: ) Line 120: ); Line 121: List<LdapUser> ldapUsers = (List<LdapUser>) ldapResult.getReturnValue(); Line 122: List<ExtMap> results = new ArrayList<>(); -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
