Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 30: (3 comments) http://gerrit.ovirt.org/#/c/26602/30/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 72: createProfiles(); Line 73: } Line 74: Line 75: private void createProfiles() throws ConfigurationException { Line 76: ExtensionsManager.getInstance().dump(); this cannot be here as we do want to use extensions for other stuff than aaa Line 77: Line 78: // Get the extensions that correspond to authn (authentication) service. Line 79: // For each extension - get the relevant authn extension. Line 80: http://gerrit.ovirt.org/#/c/26602/30/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/header/HeaderAuthn.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/header/HeaderAuthn.java: Line 54: * directory.type=nop Line 55: * </pre> Line 56: */ Line 57: public class HeaderAuthn implements Extension { Line 58: private static final Logger log = LoggerFactory.getLogger(HeaderAuthn.class); please remove this extension. Line 59: Line 60: /** Line 61: * The name of the header that contains the name of the user already authenticated by the web server. Line 62: */ http://gerrit.ovirt.org/#/c/26602/30/backend/manager/modules/builtin-extensions/src/main/resources/META-INF/services/org.ovirt.engine.api.extensions.Extension File backend/manager/modules/builtin-extensions/src/main/resources/META-INF/services/org.ovirt.engine.api.extensions.Extension: Line 1: org.ovirt.engine.extensions.aaa.builtin.internal.InternalAuthn Line 2: org.ovirt.engine.extensions.aaa.builtin.internal.InternalAuthz Line 3: org.ovirt.engine.extensions.aaa.builtin.kerberosldap.KerberosLdapAuthz Line 4: org.ovirt.engine.extensions.aaa.builtin.kerberosldap.KerberosLdapAuthn Line 5: org.ovirt.engine.extensions.aaa.builtin.header.HeaderAuthn please remove this extension -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
