Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 32: (1 comment) http://gerrit.ovirt.org/#/c/26602/32/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java: Line 107: } Line 108: // TODO: revisit this, as fetchPrincipalRecord is supposed to get authentication record Line 109: // that was returned from authentication. Line 110: ExtMap authRecord = new ExtMap(); Line 111: DirectoryUser directoryUser = AuthzUtils.fetchPrincipalRecord(authz, authRecord); this is yet to be fixed Line 112: if (directoryUser == null) { Line 113: log.info( Line 114: "Can't login user \"{}\" with authentication profile \"{}\" because the user doesn't exist in the " + Line 115: "directory.", -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
