Kobi Ianko has posted comments on this change. Change subject: Adding support in CPU monitoring ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27240/1/mom/Collectors/GuestCpuTune.py File mom/Collectors/GuestCpuTune.py: Line 37: def collect(self): Line 38: stat = self.hypervisor_iface.getUserVmCpuTuneInfo(self.uuid) Line 39: stat.update(self.hypervisor_iface.getVmCpuTuneInfo(self.uuid)) Line 40: stat['vcpu_count'] = self.hypervisor_iface.getVmCpuCount Line 41: if stat == None: > If stat is None then the update line will crash Done Line 42: self.stats_error('getVmCpuTuneInfo() is not ready') Line 43: else: Line 44: self.cpu_tune_info_available = True Line 45: http://gerrit.ovirt.org/#/c/27240/1/mom/HypervisorInterfaces/libvirtInterface.py File mom/HypervisorInterfaces/libvirtInterface.py: Line 253: Line 254: if metadataCpuLimit: Line 255: ret['user_vcpu_limit'] = metadataCpuLimit Line 256: else: Line 257: ret['user_vcpu_quota'] = 100 > shouldn't the else part set the limit to 100 instead of quota? yes, good catch Line 258: Line 259: return ret Line 260: Line 261: def getVmCpuTuneInfo(self, uuid): -- To view, visit http://gerrit.ovirt.org/27240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31428499ae7b34cafa3eacf5ca0d7a39eabe23ec Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
