Mike Kolesnik has posted comments on this change. Change subject: core: MacPoolManager does not delegate ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26793/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java: Line 2: Line 3: import org.ovirt.engine.core.common.config.Config; Line 4: import org.ovirt.engine.core.common.config.ConfigValues; Line 5: Line 6: public class MacPoolManager { > Now the better name is MacPoolManagerStrategyFactory IMHO I agree with Yevgeny, in fact this class can remain and contain all the logic for thread-safety while the factory is responsible for the acquiring the correctly scoped manager (currently it would be only the default). Line 7: Line 8: private final MacPoolManagerStrategy defaultScope; Line 9: Line 10: private static final MacPoolManager INSTANCE = new MacPoolManager(); -- To view, visit http://gerrit.ovirt.org/26793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a6f353095e52088fbf3e7e0e9c1fe624a7e7cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
