Yevgeny Zaspitsky has posted comments on this change. Change subject: core: MacPoolManager does not delegate ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26793/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java: Line 19: final Boolean allowDuplicates = Config.getValue(ConfigValues.AllowDuplicateMacAddresses); Line 20: return new MacPoolManagerRanges(maxMacsCountInPool, macPoolRanges, allowDuplicates); Line 21: } Line 22: Line 23: public static MacPoolManagerStrategy getInstance() { This is very unintuitive. Method MacPoolManager.getInstance returns a MacPoolManagerStrategy! Line 24: return INSTANCE.defaultScope; Line 25: } -- To view, visit http://gerrit.ovirt.org/26793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a6f353095e52088fbf3e7e0e9c1fe624a7e7cd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
