Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27524/6/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 80: ) Line 81: if not ( Line 82: (int(odwhcons.Const.VERSION_MAJOR) == int(minMajor)) and Line 83: (int(odwhcons.Const.VERSION_MINOR) == int(minMinor)) and Line 84: (int(odwhcons.Const.VERSION_PATCH_LEVEL) >= int(minPatchLevel)) > Good question. These are the setup versions. I think that's ok. update will we do not allow to setup if there are updates, so it is ok for now. even if we require some other logic, please stop thinking of distribution specific... I beg. a simple solution would be to install at /usr/share a file with version for us to read. Line 85: ): Line 86: raise RuntimeError( Line 87: _( Line 88: 'Minimal supported DWH version ({minimal}) is ' -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
