Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27524/6/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 80: ) Line 81: if not ( Line 82: (int(odwhcons.Const.VERSION_MAJOR) == int(minMajor)) and Line 83: (int(odwhcons.Const.VERSION_MINOR) == int(minMinor)) and Line 84: (int(odwhcons.Const.VERSION_PATCH_LEVEL) >= int(minPatchLevel)) > On my opinion minMajor and minMinor names are a bit confusing: if we are ex I might agree with you on this, but that's also the name in the engine's db, and I do not think we are going to rename that. Also, one can always hope that in the future we'll loosen our requirement... Line 85: ): Line 86: raise RuntimeError( Line 87: _( Line 88: 'Minimal supported DWH version ({minimal}) is ' -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
