Alon Bar-Lev has posted comments on this change. Change subject: core : Add ability to listen for extension registration ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27602/4/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 229: alreadyLoadedEntry.getFileName() Line 230: )); Line 231: } Line 232: loadedEntries.put(entry.name, entry); Line 233: notifyObservers(); oh! I am sorry... this should be at: end of function, no? as the other object may call us back and find nothing. Line 234: entry.enabled = Line 235: EngineLocalConfig.getInstance().getBoolean(ENGINE_EXTENSION_ENABLED + entry.name, entry.enabled); Line 236: //Activate the extension Line 237: if (entry.enabled && entry.extension == null) { -- To view, visit http://gerrit.ovirt.org/27602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd78e7a390c2a45062be1741548e370a205bfe24 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
