Yair Zaslavsky has posted comments on this change. Change subject: core : Add ability to listen for extension registration ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27602/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 318: log.error(ex.toString(), ex); Line 319: } Line 320: } Line 321: } Line 322: notifyObservers(); IMHO a call to setChanged() is missing somewhere... Line 323: } Line 324: Line 325: private Extension loadExtension(Properties props) throws Exception { Line 326: Extension extension; -- To view, visit http://gerrit.ovirt.org/27602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd78e7a390c2a45062be1741548e370a205bfe24 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
