Oved Ourfali has posted comments on this change. Change subject: core: Foreman discovery host integration to ovirt ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27621/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java: Line 13: List<VDS> getFiltered(String filter); Line 14: List<ExternalDiscoveredHost> getDiscoveredHosts(); Line 15: List<ExternalHostGroup> getHostGroups(); Line 16: Line 17: void ProvisionHost(VDS vds, ExternalHostGroup hg, String mac, String discoverName, String rootPassword); change to: provisionHost (will solve findbugs warning). -- To view, visit http://gerrit.ovirt.org/27621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c25a544373d8ab4a7123137c8a4697205a8efa8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
