Oved Ourfali has posted comments on this change. Change subject: core: Foreman discovery host integration to ovirt ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27621/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 281: " \"ip\": \"\",\n" + Line 282: " \"provider\": \"IPMI\"\n" + Line 283: " }\n" + Line 284: " },\n" + Line 285: " \"architecture_id\": \"1\",\n" + So we're always selecting the first one, right? Would that always work? Line 286: " \"operatingsystem_id\": \"" + hg.getOsId() + "\",\n" + Line 287: " \"provision_method\": \"build\",\n" + Line 288: " \"build\": \"1\",\n" + Line 289: " \"medium_id\": \"" + mediaId + "\",\n" + Line 284: " },\n" + Line 285: " \"architecture_id\": \"1\",\n" + Line 286: " \"operatingsystem_id\": \"" + hg.getOsId() + "\",\n" + Line 287: " \"provision_method\": \"build\",\n" + Line 288: " \"build\": \"1\",\n" + what "build"? is it a boolean? So we're always selecting the one? Would that always work? Line 289: " \"medium_id\": \"" + mediaId + "\",\n" + Line 290: " \"ptable_id\": \"6\",\n" + Line 291: " \"disk\": \"\",\n" + Line 292: " \"root_pass\": \"" + rootPassword + "\",\n" + Line 286: " \"operatingsystem_id\": \"" + hg.getOsId() + "\",\n" + Line 287: " \"provision_method\": \"build\",\n" + Line 288: " \"build\": \"1\",\n" + Line 289: " \"medium_id\": \"" + mediaId + "\",\n" + Line 290: " \"ptable_id\": \"6\",\n" + what's "6"? Line 291: " \"disk\": \"\",\n" + Line 292: " \"root_pass\": \"" + rootPassword + "\",\n" + Line 293: " \"host_parameters_attributes\": {\n" + Line 294: " \"\": {\n" + -- To view, visit http://gerrit.ovirt.org/27621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c25a544373d8ab4a7123137c8a4697205a8efa8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
