Martin Mucha has posted comments on this change. Change subject: core: extract current implementation to strategy. ......................................................................
Patch Set 7: (2 comments) answers. http://gerrit.ovirt.org/#/c/26400/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerOriginal.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerOriginal.java: Line 55: Line 56: private final ReentrantReadWriteLock lockObj = new ReentrantReadWriteLock(); Line 57: private boolean initialized; Line 58: Line 59: public MacPoolManagerOriginal(Integer maxMacsInPool, String ranges, Boolean allowDuplicates) { > Since allowDuplicates is now primitive, I think it makes more sense that th Done Line 60: this.maxMacsInPool = maxMacsInPool; Line 61: this.ranges = ranges; Line 62: this.allowDuplicates = allowDuplicates; Line 63: } Line 130: log.errorFormat("{0}: Failed to initialize Mac Pool range. Please fix Mac Pool range: <{1}, {2}>", Line 131: instanceId(), Line 132: start, Line 133: end); Line 134: throw new MacPoolExceededMaxException(); //TODO MM: what's this? why returning boolean value then? > Unnecessary comment Done Line 135: } else { Line 136: availableMacs.addAll(macAddresses); Line 137: } Line 138: } -- To view, visit http://gerrit.ovirt.org/26400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75498bb68ec6dbe28650027116bf44a0797faf93 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
