Mike Kolesnik has posted comments on this change. Change subject: core: extract current implementation to strategy. ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/26400/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerStrategy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerStrategy.java: Line 9: */ Line 10: void initialize(); Line 11: Line 12: /** Line 13: * Empty line not necessary Line 14: * @return free MAC from pool. Line 15: */ Line 16: String allocateNewMac(); Line 17: Line 10: void initialize(); Line 11: Line 12: /** Line 13: * Line 14: * @return free MAC from pool. What if no more macs in pool? Line 15: */ Line 16: String allocateNewMac(); Line 17: Line 18: /** Line 54: void freeMacs(List<String> macs); Line 55: Line 56: /** Line 57: * @param numberOfAddresses The number of MAC addresses to allocate Line 58: * @return The list of MAC addresses, sorted in ascending order What if there aren't enough MACs in the pool? Line 59: */ Line 60: List<String> allocateMacAddresses(int numberOfAddresses); Line 61: Line 62: -- To view, visit http://gerrit.ovirt.org/26400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75498bb68ec6dbe28650027116bf44a0797faf93 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
