Yair Zaslavsky has uploaded a new change for review. Change subject: aaa: Fix ExtMap.get with default value ......................................................................
aaa: Fix ExtMap.get with default value The implementation before the fix failed to support a case where the default value was a subclass of the type associated with the ExtKey Change-Id: Ib9d04c4650ff0a01866ffd7edf2cce6801d422a1 Topic: AAA Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/27660/1 diff --git a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java index 2ca4b63..91d35e9 100644 --- a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java +++ b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java @@ -388,7 +388,7 @@ * @return Value. */ public <T> T get(ExtKey key, T defaultValue) { - if (!defaultValue.getClass().isAssignableFrom(key.getType())) { + if (!key.getType().isAssignableFrom(defaultValue.getClass())) { throw new IllegalArgumentException( String.format( "Cannnot assign default value of '%s' into type '%s'", -- To view, visit http://gerrit.ovirt.org/27660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9d04c4650ff0a01866ffd7edf2cce6801d422a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
